Skip to content

Commit

Permalink
Merge pull request #60 from Christine-horrocks/katylouise/image_url_d…
Browse files Browse the repository at this point in the history
…ocker

Added necessary environment variables for tests in GoCD
  • Loading branch information
mattrayner committed Sep 14, 2018
2 parents 82f4df4 + ee8bf84 commit 31c6a7b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ ARG APPLICATION_INSIGHTS_INSTRUMENTATION_KEY
ARG RAILS_LOG_TO_STDOUT
ARG SECRET_KEY_BASE
ARG RACK_ENV=production
ARG IMAGE_SERVICE_URL
ARG PARLIAMENT_BASE_URL

# Add Gemfiles.
ADD Gemfile /app/
Expand Down Expand Up @@ -55,6 +57,8 @@ ENV RAILS_LOG_TO_STDOUT $RAILS_LOG_TO_STDOUT
ENV RACK_ENV $RACK_ENV
ENV SECRET_KEY_BASE $SECRET_KEY_BASE
ENV RAILS_SERVE_STATIC_FILES true
ENV IMAGE_SERVICE_URL $IMAGE_SERVICE_URL
ENV PARLIAMENT_BASE_URL $PARLIAMENT_BASE_URL

# Add additional labels to our image
ARG GIT_SHA=unknown
Expand Down
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ build: # Using the variables defined above, run `docker build`, tagging the imag
--build-arg RACK_ENV=$(RACK_ENV) \
--build-arg GIT_SHA="$(GIT_SHA)" \
--build-arg GIT_TAG="$(GIT_TAG)" \
--build-arg IMAGE_SERVICE_URL="$(IMAGE_SERVICE_URL)" \
--build-arg PARLIAMENT_BASE_URL="$(PARLIAMENT_BASE_URL)" \
.

run: # Run the Docker image we have created, mapping the HOST_PORT and CONTAINER_PORT
Expand Down

0 comments on commit 31c6a7b

Please sign in to comment.