Merge pull request #310 from uktrade/bug/select-option-initial-value-fix

fix: select option fix
uktrade · Jun 25, 2020 · 590419a · 590419a
2 parents 9e2c687 + 9d1c346
commit 590419a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/forms/elements/FieldSelect.jsx b/src/forms/elements/FieldSelect.jsx
@@ -32,8 +32,7 @@ const FieldSelect = ({
         meta={{ error, touched }}
         input={{
           id: name,
-          value,
-          readOnly: true,
+          defaultValue: value,
           ...rest,
         }}
       >

diff --git a/src/forms/elements/__tests__/FieldSelect.test.jsx b/src/forms/elements/__tests__/FieldSelect.test.jsx
@@ -175,12 +175,19 @@ describe('FieldSelect', () => {
         .simulate('change', { target: { value: 'testOptionValue2' } })
     })
 
-    test('should update the field value', () => {
-      expect(wrapper.find('select').prop('value')).toEqual('testOptionValue2')
+    test('should update the defaultValue', () => {
+      expect(wrapper.find('select').prop('defaultValue')).toEqual(
+        'testOptionValue2'
+      )
     })
 
-    test('should set the readonly flag', () => {
-      expect(wrapper.find('select').prop('readOnly')).toEqual(true)
+    test('should have a selected attribute', () => {
+      expect(
+        wrapper
+          .find('select option')
+          .first()
+          .html()
+      ).toContain('selected')
     })
 
     test('should update value in form state', () => {