COCOS-100 - Isolate the algorithm execution from Agent #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
requested changes
May 8, 2024
agent/service.go
Outdated
Comment on lines
321
to
348
| // if err := syscall.Mount("proc", "/proc", "proc", 0, ""); err != nil { | ||
| // fmt.Println("failed to mount /proc: ", err) | ||
| // os.Exit(1) | ||
| // } | ||
|
|
agent/service.go
Outdated
| @@ -51,6 +52,10 @@ var ( | |||
| errStateNotReady = errors.New("agent not expecting this operation in the current state") | |||
| // errHashMismatch provided algorithm/dataset does not match hash in manifest. | |||
| errHashMismatch = errors.New("malformed data, hash does not match manifest") | |||
|
|
|||
| // new root directory | |||
There was a problem hiding this comment.
No need for this comment.
danko-miladinovic
force-pushed
the
hal_namespaces
branch
from
25fa7b4
to
c939337
Compare
danko-miladinovic
changed the title
danko-miladinovic
changed the title
There is a problem with |
|
Closed in favor of Docker and Wasm runtimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR fixes the following issues:
#100
#65
What does this do?
This PR creates a Linux Namespace for the algorithm executable so that it cannot interfere with the Agent or the kernel.
Which issue(s) does this PR fix/relate to?
Resolves:
#100
#65
Have you included tests for your changes?
The tests will be included.
Did you document any new/modified feature?
The documentation will be updated in a separate PR to the cocos-docs repository.
Notes