-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COCOS-100 - Isolate the algorithm execution from Agent #120
COCOS-100 - Isolate the algorithm execution from Agent #120
Conversation
agent/service.go
Outdated
// if err := syscall.Mount("proc", "/proc", "proc", 0, ""); err != nil { | ||
// fmt.Println("failed to mount /proc: ", err) | ||
// os.Exit(1) | ||
// } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
agent/service.go
Outdated
@@ -51,6 +52,10 @@ var ( | |||
errStateNotReady = errors.New("agent not expecting this operation in the current state") | |||
// errHashMismatch provided algorithm/dataset does not match hash in manifest. | |||
errHashMismatch = errors.New("malformed data, hash does not match manifest") | |||
|
|||
// new root directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
25fa7b4
to
c939337
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one ready?
There is a problem with |
Closed in favor of Docker and Wasm runtimes |
What type of PR is this?
This PR fixes the following issues:
#100
#65
What does this do?
This PR creates a Linux Namespace for the algorithm executable so that it cannot interfere with the Agent or the kernel.
Which issue(s) does this PR fix/relate to?
Resolves:
#100
#65
Have you included tests for your changes?
The tests will be included.
Did you document any new/modified feature?
The documentation will be updated in a separate PR to the cocos-docs repository.
Notes