Refactor manager to start AMD SEV encrypted VM #10

darkodraskovic · 2023-07-14T11:35:35Z

resolves #30
resolves #32

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

drasko

Just a note - we should be able to start it on both SEV-SNP (default setup), but also on an ordinary PC without an enclave - for test, demo and development purposes, to deploy quickly manager on local PCs (very useful when we develop other parts of the system, like UI, but we need end-to-end functionality).

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

…rvice Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

…ings Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

…aunch Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

cmd/manager/main.go

internal/cmd.go

manager/api/http/requests.go

manager/api/http/transport.go

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic · 2023-08-16T09:10:22Z

Just a note - we should be able to start it on both SEV-SNP (default setup), but also on an ordinary PC without an enclave - for test, demo and development purposes, to deploy quickly manager on local PCs (very useful when we develop other parts of the system, like UI, but we need end-to-end functionality).

It's already addressed by the proper use of env vars, especially env vars that are SEV and sudo related and properly documented in README.

drasko · 2023-08-16T10:27:29Z

README.md

+
+### Verifying VM launch
+
+NB: To verify that the manager successfully launched the VM, you need to open two terminals on the same machine. In one terminal, you need to launch `go run main.go` (with the environment variables of choice) and in the other, you can run the verification commands.


In the future, we need to verify this programmatically - i.e. Manager must be capable of observing and monitoring VM log and verifying if everything is going OK.

If you are launching several VMs, you will have to keep track of all of them.

There's an issue opened for this #35

drasko · 2023-08-16T10:28:07Z

manager/api/http/transport.go

 		encodeResponse,
 		opts...,
 	), "create_domain"))

+	r.Get("/qemu", otelhttp.NewHandler(kithttp.NewServer(


We do not need separate endpoint, this is done via /run

We will do it in the next issue: #36, let's merge this one now.

drasko · 2023-08-16T13:21:37Z

manager/api/http/transport.go

 		encodeResponse,
 		opts...,
 	), "create_domain"))

+	r.Get("/qemu", otelhttp.NewHandler(kithttp.NewServer(


We will do it in the next issue: #36, let's merge this one now.

darkodraskovic force-pushed the manger_SEV branch from d0e0d70 to 441366c Compare July 14, 2023 11:41

darkodraskovic added 3 commits July 31, 2023 12:23

Refactor manager to start AMD SEV encrypted VM

10e2a6d

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add proper formatting

eaef7dd

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Add host-guest http and grpc port parametrization

b92c698

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

drasko reviewed Jul 31, 2023

View reviewed changes

darkodraskovic force-pushed the manger_SEV branch from 3e7b959 to b92c698 Compare July 31, 2023 14:17

Refactor dom.xml to start focal-server-cloudimg-amd64.qcow2

b92806c

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic changed the title ~~DRAFT - Refactor manager to start AMD SEV encrypted VM~~ Refactor manager to start AMD SEV encrypted VM Aug 4, 2023

darkodraskovic force-pushed the manger_SEV branch 2 times, most recently from 860e647 to b7662c8 Compare August 7, 2023 14:04

Add uefi bios vars, exec cmd line and log to file parameters

f6d5b61

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch 2 times, most recently from 4cec272 to 0b64337 Compare August 7, 2023 15:46

Parse env vars for qemu cmd line config

ada7cb9

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from 0b64337 to ada7cb9 Compare August 7, 2023 15:46

darkodraskovic added 3 commits August 7, 2023 18:37

Add ConstructQemuCommand and fix guestgrpc bug in sh

6294117

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Remove sudo necessity

ff47905

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Replace cmd.Output() with cmd.Start()

9c545d3

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from 4197ff3 to 9c545d3 Compare August 8, 2023 16:10

Add a tmp file to read qemu cmd line constr output

3caaf6a

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from c7de96c to 3caaf6a Compare August 9, 2023 13:57

darkodraskovic added 2 commits August 9, 2023 16:05

Add sudo env var

1012d2c

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Remove tmp file creation and capture stdout with buffer

7e21a17

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from 1a2a47b to 7e21a17 Compare August 10, 2023 08:57

Move cmd funcs to internal/cmd.go

d7aca93

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from 0f97eab to de77be9 Compare August 12, 2023 21:10

Replace sh script for ctor of qemu cmd line with go code

51e69d8

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch 3 times, most recently from 5528417 to 5095ff6 Compare August 12, 2023 21:50

darkodraskovic self-assigned this Aug 14, 2023

darkodraskovic added the feature introducing new functionality label Aug 14, 2023

darkodraskovic added this to the Open source Cocos AI milestone Aug 14, 2023

darkodraskovic force-pushed the manger_SEV branch from 8d25cb3 to a97e983 Compare August 14, 2023 14:08

Refactor README to use focal-server-cloudimg-amd64.img

88e05ae

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from a97e983 to 88e05ae Compare August 14, 2023 14:23

Add VM launch troubleshooting instructions

08f26af

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from 36767b5 to 08f26af Compare August 14, 2023 18:45

darkodraskovic added 2 commits August 14, 2023 22:32

Add ExecutableAndArgs generator func to qemu and qemuCmd struct to se…

5558a4f

…rvice Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

Amend VM launch troubleshooting instructions with port forwaring sett…

4137ad3

…ings Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch 3 times, most recently from dae290e to c8c191e Compare August 15, 2023 12:56

Add CreateQemuVM endoint

6b4a708

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from c8c191e to 6b4a708 Compare August 15, 2023 13:32

Revert to env var VM parametrization

1536c6c

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch 2 times, most recently from 5b01c8d to afe4d62 Compare August 15, 2023 18:21

Add uuid to VM creation config id fields

0b38e94

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from afe4d62 to 0b38e94 Compare August 15, 2023 18:28

Add file.go and temporary file creation to enable multi instance VM l…

b3ad784

…aunch Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

darkodraskovic force-pushed the manger_SEV branch from efbf53c to b3ad784 Compare August 15, 2023 19:47

dborovcanin requested changes Aug 16, 2023

View reviewed changes

Replace literal strings by consts and properly format godoc comments

5028946

Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>

dborovcanin approved these changes Aug 16, 2023

View reviewed changes

drasko requested changes Aug 16, 2023

View reviewed changes

drasko approved these changes Aug 16, 2023

View reviewed changes

drasko merged commit 2cf6e1a into main Aug 16, 2023
1 check passed

darkodraskovic deleted the manger_SEV branch August 16, 2023 18:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor manager to start AMD SEV encrypted VM #10

Refactor manager to start AMD SEV encrypted VM #10

darkodraskovic commented Jul 14, 2023 •

edited

Loading

drasko left a comment

darkodraskovic commented Aug 16, 2023 •

edited

Loading

drasko Aug 16, 2023

darkodraskovic Aug 16, 2023

drasko Aug 16, 2023

drasko Aug 16, 2023

drasko Aug 16, 2023


		### Verifying VM launch

		NB: To verify that the manager successfully launched the VM, you need to open two terminals on the same machine. In one terminal, you need to launch `go run main.go` (with the environment variables of choice) and in the other, you can run the verification commands.

Refactor manager to start AMD SEV encrypted VM #10

Refactor manager to start AMD SEV encrypted VM #10

Conversation

darkodraskovic commented Jul 14, 2023 • edited Loading

drasko left a comment

Choose a reason for hiding this comment

darkodraskovic commented Aug 16, 2023 • edited Loading

drasko Aug 16, 2023

Choose a reason for hiding this comment

darkodraskovic Aug 16, 2023

Choose a reason for hiding this comment

drasko Aug 16, 2023

Choose a reason for hiding this comment

drasko Aug 16, 2023

Choose a reason for hiding this comment

drasko Aug 16, 2023

Choose a reason for hiding this comment

darkodraskovic commented Jul 14, 2023 •

edited

Loading

darkodraskovic commented Aug 16, 2023 •

edited

Loading