-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor manager to start AMD SEV encrypted VM #10
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
10e2a6d
Refactor manager to start AMD SEV encrypted VM
darkodraskovic eaef7dd
Add proper formatting
darkodraskovic b92c698
Add host-guest http and grpc port parametrization
darkodraskovic b92806c
Refactor dom.xml to start focal-server-cloudimg-amd64.qcow2
darkodraskovic f6d5b61
Add uefi bios vars, exec cmd line and log to file parameters
darkodraskovic ada7cb9
Parse env vars for qemu cmd line config
darkodraskovic 6294117
Add ConstructQemuCommand and fix guestgrpc bug in sh
darkodraskovic ff47905
Remove sudo necessity
darkodraskovic 9c545d3
Replace cmd.Output() with cmd.Start()
darkodraskovic 3caaf6a
Add a tmp file to read qemu cmd line constr output
darkodraskovic 1012d2c
Add sudo env var
darkodraskovic 7e21a17
Remove tmp file creation and capture stdout with buffer
darkodraskovic d7aca93
Move cmd funcs to internal/cmd.go
darkodraskovic 51e69d8
Replace sh script for ctor of qemu cmd line with go code
darkodraskovic 475004c
Add use sudo option to qemu command ctor
darkodraskovic ce6131e
Add programmatic qemu bin abs path config
darkodraskovic 88e05ae
Refactor README to use focal-server-cloudimg-amd64.img
darkodraskovic 08f26af
Add VM launch troubleshooting instructions
darkodraskovic 5558a4f
Add ExecutableAndArgs generator func to qemu and qemuCmd struct to se…
darkodraskovic 4137ad3
Amend VM launch troubleshooting instructions with port forwaring sett…
darkodraskovic 6b4a708
Add CreateQemuVM endoint
darkodraskovic 1536c6c
Revert to env var VM parametrization
darkodraskovic 0b38e94
Add uuid to VM creation config id fields
darkodraskovic b3ad784
Add file.go and temporary file creation to enable multi instance VM l…
darkodraskovic 5028946
Replace literal strings by consts and properly format godoc comments
darkodraskovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, we need to verify this programmatically - i.e. Manager must be capable of observing and monitoring VM log and verifying if everything is going OK.
If you are launching several VMs, you will have to keep track of all of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue opened for this #35