Fixing Potentially unsafe external link

see: https://github.com/ulynks/fixie/security/code-scanning/1
ulynks · Feb 22, 2024 · d3b8b11 · d3b8b11
1 parent 1d76fce
commit d3b8b11
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/public/assets/bundle.js b/public/assets/bundle.js
diff --git a/public/sdu/index.html b/public/sdu/index.html
@@ -62,8 +62,7 @@
   </iframe>
 </main>
 <footer class="Footer py-3">
-  <p><a class="fgColor-default" href="https://www.ulynks.io/" target="_blank"
-      rel="noopener noreferrer">Fixie Agents by uLynks Copyright
+  <p><a class="fgColor-default" href="https://www.ulynks.io/">Fixie Agents by uLynks Copyright
       2024</a>. All rights reserved.
   </p>
 </footer></div><script src="https://cdn.jsdelivr.net/npm/jquery@3.7.1/dist/jquery.min.js"

diff --git a/static/assets/bundle.js b/static/assets/bundle.js
diff --git a/themes/ulynks/assets/js/app.js b/themes/ulynks/assets/js/app.js
@@ -36,7 +36,7 @@ $(function () {
    */
   $("a[href^='http']").each(function () {
     /* console.debug('_link', this.href); */
-    $(this).attr('target', '_blank')
+    $(this).attr({ 'target': '_blank', 'rel': 'noopener noreferrer' })
   })
 });
 

diff --git a/themes/ulynks/layouts/partials/footer.html b/themes/ulynks/layouts/partials/footer.html
@@ -1,6 +1,5 @@
 <footer class="Footer py-3">
-  <p><a class="fgColor-default" href="{{ .Site.Params.mainWebsite }}" target="_blank"
-      rel="noopener noreferrer">{{ .Site.Title }} Copyright
+  <p><a class="fgColor-default" href="{{ .Site.Params.mainWebsite }}">{{ .Site.Title }} Copyright
       {{ now.Year }}</a>. All rights reserved.
   </p>
 </footer>