Support reacting literally with non-Emojis #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssa
force-pushed
the
non-emoji-reactions
branch
from
0709df9
to
9ec8b19
Compare
This was referenced Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks were talking about custom reactions and literal text reactions in the
#offtopic:archlinux.orgroom earlier tonight. This PR changes:react/:unreactto prompt whether you want to use the literal text when it's not a shortcode, and allows using:react!/:unreact!to force it to be interpreted literally. (So:react wavesends the 👋 Emoji, and:react! wavereacts with the literal text "wave".)I'd love to eventually support something like MSC4027, but that'll have to wait for some future PR.