(WIP) compute the backward pass only once for all three slots in negative sampling #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgemulla
reviewed
Aug 31, 2020
| @@ -312,6 +312,13 @@ negative_sampling: | |||
| # 'triple' (e.g., for TransE or RotatE in the current implementation). | |||
| implementation: triple | |||
|
|
|||
| # Whether to compute the backward pass after scoring against each slot (S, P, O) | |||
| # or once after scoring against all three slots. | |||
| # Does not work with reciprocal relations. | |||
There was a problem hiding this comment.
Also say that if false, positive triples are scored only once (else once per slot).
|
Another thought: shouldn't we allow this for all trainers? We may either push the backward pass into _process_batch (slow, save mem) or keep it outside (fast, more mem). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Flag to negative sampling to compute positive scores and backward pass only once for all three slots.
Unsure how to handle reciprocal relations in this setup. Can not provide direction, when scoring positive triples.