Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Swiss backoffice localizations #2503

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Conversation

marwaldv
Copy link
Contributor

@marwaldv marwaldv commented Nov 1, 2024

Add missing backoffice languages as properties etc. are translated via translation section (e.g. with "#Backoffice Settings"). I've been asked to add the swiss languages files here by @iOvergaard here umbraco/Umbraco-CMS#17177 (comment)

To reduce lines of duplicated code, (from the German, French
and Italian localizations), those localizations are imported at runtime.
@leekelleher leekelleher self-requested a review November 6, 2024 15:20
@leekelleher leekelleher changed the title Add swiss languages as backoffice languages Feature: Add Swiss backoffice localizations Nov 6, 2024
@leekelleher leekelleher enabled auto-merge (squash) November 6, 2024 15:21
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marwaldv Thank you for your pull request! 🙏

I've made a couple of amends to the pull request, firstly I added the localizations the manifest (to register them within the backoffice).

The second amend was that I'd noticed the Swiss German, French and Italian localizations were exact duplicates of the existing German, French and Italian localizations, effectively adding approx. 6,000 lines of code, so I opted to make use of the JavaScript approach and imported the native localizations, which can then be appended to if there are any future specific Swiss variations to the labels. To note, this approach would not be possible in the old backoffice (v13 and prior) due to the nature of using the XML format.

Thank you again for making this contribution. 👍

@leekelleher leekelleher merged commit 2799523 into umbraco:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants