Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Block Grid inline editing + Extension Initializers change #2513

Merged
merged 22 commits into from
Nov 7, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 5, 2024

This PR finalises the feature of Block Grid Inline Editing, which has never reached this point before, though there have been Prove of concept available.

Also notice this contains updates to Core functionality.
This PR changes Extension Initializers so they do no longer clean up extension on host disconnected. — Instead extensions gets updated in the aftermath of begin re-connected to a host. This enables things that are begin dragged around to not be disassembled and reassembled when moved around.

The reason for the change and the actual change of this PR:
The Extension Initializer did reset when manifest changed, or when hostDisconnected. This turned out not to be so great when dragging Blocks around in Block Grid Editor. Cause then a Block gets disconnected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe changed the title Feature: inline editing fixes Feature: Block Grid inline editing fixes Nov 5, 2024
@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 6, 2024 09:12
@nielslyngsoe nielslyngsoe changed the title Feature: Block Grid inline editing fixes Feature: Block Grid inline editing + Extension Initializers change Nov 6, 2024
# Conflicts:
#	src/packages/core/content/property-dataset-context/element-property-dataset.context.ts
@nielslyngsoe nielslyngsoe merged commit 99bff60 into main Nov 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants