-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Block Grid inline editing + Extension Initializers change #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
changed the title
Feature: inline editing fixes
Feature: Block Grid inline editing fixes
Nov 5, 2024
nielslyngsoe
changed the title
Feature: Block Grid inline editing fixes
Feature: Block Grid inline editing + Extension Initializers change
Nov 6, 2024
madsrasmussen
approved these changes
Nov 7, 2024
# Conflicts: # src/packages/core/content/property-dataset-context/element-property-dataset.context.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalises the feature of Block Grid Inline Editing, which has never reached this point before, though there have been Prove of concept available.
Also notice this contains updates to Core functionality.
This PR changes Extension Initializers so they do no longer clean up extension on host disconnected. — Instead extensions gets updated in the aftermath of begin re-connected to a host. This enables things that are begin dragged around to not be disassembled and reassembled when moved around.
The reason for the change and the actual change of this PR:
The Extension Initializer did reset when manifest changed, or when hostDisconnected. This turned out not to be so great when dragging Blocks around in Block Grid Editor. Cause then a Block gets disconnected.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist