Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes duplicate alias in examples/ufm-custom-component/index.ts that fails npm run compile #2517

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fixes duplicate alias in examples/ufm-custom-component/index.ts that fails npm run compile #2517

merged 1 commit into from
Nov 6, 2024

Conversation

warrenbuckley
Copy link
Contributor

Fixes issue when running npm run compile

examples/ufm-custom-component/index.ts:12:4 - error TS1117: An object literal cannot have multiple properties with the same name.

12    alias: 'myCustomComponent',
      ~~~~~


Found 1 error in examples/ufm-custom-component/index.ts:12

Description

Fixes the repo building when running npm run compile

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Make the repo & build happy

How to test?

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@warrenbuckley
Fixes duplicate alias that fails npm run compile
cb54ad1 
Fixes issue when running `npm run compile`

```
examples/ufm-custom-component/index.ts:12:4 - error TS1117: An object literal cannot have multiple properties with the same name.

12    alias: 'myCustomComponent',
      ~~~~~


Found 1 error in examples/ufm-custom-component/index.ts:12
```
nielslyngsoe
nielslyngsoe approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks dont know why this merge problem keeps re-appearing, thanks

@warrenbuckley
Copy link
Contributor Author

Seems the tests fail as well @nielslyngsoe
https://github.com/umbraco/Umbraco.CMS.Backoffice/actions/runs/11710645399/job/32617392368?pr=2517#step:6:237

@nielslyngsoe nielslyngsoe merged commit ce25a42 into umbraco:main Nov 6, 2024
9 checks passed
@warrenbuckley warrenbuckley deleted the patch-1 branch November 6, 2024 19:56
@warrenbuckley
Copy link
Contributor Author

All seems happy now 👍

@warrenbuckley warrenbuckley changed the title Fixes duplicate alias that fails npm run compile Fixes duplicate alias in examples/ufm-custom-component/index.ts that fails npm run compile Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
community/pr release/15.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warrenbuckley @nielslyngsoe @nul800sebastiaan