add content disposition header for s3 presign api #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
Merged
williamputraintan
approved these changes
Jul 11, 2024
victorskl
approved these changes
Jul 11, 2024
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
add 'Content-Disposition' header in 'preview' s3 presignurl api, and change default presignurl behaviour to download as attachment.
These may need couple modification of
libumccr.aws.libs3.presign_s3_fileto be able add 'content_disposition' params for s3 presignurl call.PR of libumccr: umccr/libumccr#28
Link: umccr/data-portal-client#342
Refer: about boto3 presign url pass disposition header: boto/boto3#356 (comment)
boto/boto3#610 (comment)