Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made cachetools optional for libssm and libsm #26

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Made cachetools optional for libssm and libsm #26

merged 1 commit into from
Mar 19, 2024

Conversation

victorskl
Copy link
Member

  • Both libssm and libsm modules will use cachetools if it
    is found in the PYTHONPATH or sys.modules. Else fetch
    from the remote.
  • Added unit tests
  • Bumped rc3 release

Resolves #2 #4 #25

@victorskl
Made cachetools optional for libssm and libsm
ab3be88 
* Both libssm and libsm modules will use cachetools if it
  is found in the PYTHONPATH or sys.modules. Else fetch
  from the remote.
* Added unit tests
* Bumped rc3 release

Resolves #2 #4 #25
This was linked to issues Mar 19, 2024
Implement libssm unittests #4
Closed
Make cachetools optional for aws package #25
Closed
@victorskl victorskl self-assigned this Mar 19, 2024
@victorskl victorskl added feature New feature or request fix labels Mar 19, 2024
victorskl
victorskl commented Mar 19, 2024
View reviewed changes
libumccr/aws/libsm.py
func.cache_clear = lambda: None
return func

return wrapper
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Higher order function and function object attribute trick here, Flo.
See if you could traceback this puzzle piece. @reisingerf 😉

@victorskl victorskl merged commit e26b290 into main Mar 19, 2024
7 checks passed
@victorskl victorskl deleted the make-cachetools-optional branch March 19, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@victorskl victorskl

Labels
feature New feature or request fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cachetools optional for aws package Implement libssm unittests Implement libsm unittests
1 participant
@victorskl