Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common OrcaBus regexes #30

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Add common OrcaBus regexes #30

merged 1 commit into from
Oct 16, 2024

Conversation

reisingerf
Copy link
Member

@reisingerf reisingerf self-assigned this Oct 15, 2024
victorskl
victorskl approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorskl
Copy link
Member

victorskl commented Oct 16, 2024 •
edited
Loading

Happy to ignore those PR build checks and merge it, Flo.
I will follow up updating those build dependencies and check point. It seems outdated.

@victorskl victorskl added this to the Release 0.4.0 milestone Oct 16, 2024
@victorskl victorskl added the feature New feature or request label Oct 16, 2024
@reisingerf reisingerf merged commit d9cb0b5 into main Oct 16, 2024
1 of 7 checks passed
@reisingerf reisingerf deleted the update/add-orcabus-regexes branch October 16, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexiswl alexiswl alexiswl approved these changes

@victorskl victorskl victorskl approved these changes

Assignees

@reisingerf reisingerf

Labels
feature New feature or request
Projects
None yet
Milestone
Release 0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reisingerf @victorskl @alexiswl