Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review of windspeed.py #67

Merged
merged 12 commits into from
May 29, 2024
Merged

review of windspeed.py #67

merged 12 commits into from
May 29, 2024

Conversation

vincelhx
Copy link
Collaborator

No description provided.

@vincelhx vincelhx marked this pull request as draft May 16, 2024 15:03
@vincelhx
Copy link
Collaborator Author

The first commint concerns cases where sigma0 <=0 or sigma0 == NaN (on the left side of the image here)

nrcs_copol
before commit :
wspd_co_before
after commit :
wspd_co_after

In this case in the previous version, xsarsea was replacing copol by ancillary and used ancillary for dualpol inversion. Now inversion returns NaN

@vincelhx
Copy link
Collaborator Author

the second change concerns the wind direction output from inversion. The returned angle was false before these commits. Now, the return complex can be used.

use this formula to get wind direction in meteorological convention :
90 - (np.angle(-np.conj(wind_xsarsea), deg=True)) + xr_dataset.ground_heading) % 360

@vincelhx
Copy link
Collaborator Author

Lut being symetrical, i chose phi or -phi by taking the closest angle from ancillary.

@vincelhx vincelhx marked this pull request as ready for review May 27, 2024 13:51
@vincelhx
Copy link
Collaborator Author

i also updated documentation. make html is ok @agrouaze

@vincelhx
Copy link
Collaborator Author

added cmod7 gmf

Copy link
Member

@agrouaze agrouaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the notebook windspeed_inversion to check .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check this notebook is output free?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name of the script other_luts.py is a bit weird but you are the one that play the more with this lib.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed!

@agrouaze agrouaze merged commit a5c1e80 into umr-lops:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants