-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
review of windspeed.py #67
Conversation
the second change concerns the wind direction output from inversion. The returned angle was false before these commits. Now, the return complex can be used. use this formula to get wind direction in meteorological convention : |
Lut being symetrical, i chose phi or -phi by taking the closest angle from ancillary. |
i also updated documentation. make html is ok @agrouaze |
added cmod7 gmf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the notebook windspeed_inversion to check .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this notebook is output free?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/xsarsea/windspeed/other_luts.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name of the script other_luts.py is a bit weird but you are the one that play the more with this lib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed!
No description provided.