Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache attribute table #22

Open
jonathan-marsan opened this issue Jul 18, 2016 · 1 comment
Open

Cache attribute table #22

jonathan-marsan opened this issue Jul 18, 2016 · 1 comment

Comments

@jonathan-marsan
Copy link
Contributor

For GetAttribute... functions, need to find a way to cache the table so the table isn't fetched every time one of the functions is used.

@yosemsweet
Copy link
Contributor

The way I approached this for KissReport and KissReports is to create an empty env within the S3 object, and then in the read function I first check to see if we already have the appropriate data in the cache using readCache from utilities.R and if not then we'll load the data and write it to cache using writeCache.

You might also consider adding a refresh_cache flag to the read call, as the url for properties and events never changes so our cache keys shouldn't change. By providing an optional flag we can support new attributes being added during a session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants