last comment

unfoldtoolbox · Nov 6, 2024 · 6d0f735 · 6d0f735
1 parent 4f060cd
commit 6d0f735
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/docs/literate/intro/speed.jl b/docs/literate/intro/speed.jl
@@ -5,7 +5,8 @@
 # - Single topoplot
 # - Topoplot series with 50 topoplots
 # - Topoplott animation with 50 timestamps
-
+#
+# Note that the results of benchmarking on your computer and on Github may differ. 
 using UnfoldMakie
 using TopoPlots
 using PyMNE
@@ -76,8 +77,9 @@ simulated_epochs = PyMNE.EvokedArray(Py(dat[:, :, 1]), info)
 
 # MATLAB
 #
-# It is not easy to run MATLAB as a GitHub action. Therefore, we provided execution times of three consecutive executions.
-# Executions were performed on a server with an AMD EPYC 7452 32-core processor.
+# Running MATLAB on a GitHub Action is not easy. 
+# So we benchmarked three consecutive executions (on a screenshot) on a server with an AMD EPYC 7452 32-core processor.
+# Note that Github and the server we used for MATLAB benchmarking are two different computers, which can give different timing results.
 
 # ```@raw html
 # <img src="../../../assets/MATLAB_benchmarking.png" align="middle"/>

diff --git a/docs/literate/tutorials/butterfly.jl b/docs/literate/tutorials/butterfly.jl
@@ -103,7 +103,7 @@ plot_butterfly(
     visual = (; color = 1:2, colormap = [gray, :red]),
 )
 
-# # Column Mappings for Butterfly Plot
+# # Column Mappings
 
 # Since butterfly plots use a `DataFrame` as input, the library needs to know the names of the columns used for plotting. You can set these mapping values by calling `plot_butterfly(...; mapping=(; :x=:time))`. Just specify a `NamedTuple`. Note the `;` right after the opening parentheses.
 

diff --git a/src/plotconfig.jl b/src/plotconfig.jl
@@ -96,7 +96,7 @@ function PlotConfig(T::Val{:topoplot})
             labels = (:labels, :label, :sensor, nothing), # String
         ),
         colorbar = (; flipaxis = true, label = "Voltage"),
-        axis = (; xlabel = "", aspect = DataAspect()),
+        axis = (; xlabel = "Time", aspect = DataAspect()),
     )
     return cfg
 end

diff --git a/src/supportive_defaults.jl b/src/supportive_defaults.jl
@@ -40,7 +40,7 @@ function supportive_defaults(cfg_symb::Symbol)
     elseif cfg_symb == :meanplot_default
         return (;
             height = 100,
-            xlabel = "Time [s]",
+            xlabel = "Time",
             xlabelpadding = 0,
             xautolimitmargin = (0, 0),
         )