Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete rewrite of parallel plots #121

Merged
merged 16 commits into from
Nov 30, 2023
Merged

complete rewrite of parallel plots #121

merged 16 commits into from
Nov 30, 2023

Conversation

behinger
Copy link
Member

@behinger behinger commented Nov 25, 2023

  • check that the bended lines fit exactly through the original datapoints
  • provide a bending parameter
  • optional axis ticks for middle axes (looks probably better for many axes)
  • option to put axis label on top of axis

@behinger
Copy link
Member Author

behinger commented Nov 26, 2023

a,b,c,d = UnfoldMakie.parallelplot(Figure(),[0 1 0 2 0 3 0 4.; -1 0 -2 0 -3 0 -4 0]',normalize=:no,bend=true);a

grafik

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (acff4b9) 85.46% compared to head (97c85fe) 86.24%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/plot_parallelcoordinates.jl 99.21% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   85.46%   86.24%   +0.77%     
==========================================
  Files          18       18              
  Lines         640      698      +58     
==========================================
+ Hits          547      602      +55     
- Misses         93       96       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@behinger
Copy link
Member Author

  • bending parameter is tricky. I settled for cubic splines for now - if we would allow more bending, we would not hit all data-points. So let's keep that for now.
  • Ticks: I added the functionality (wasnt that easy :S) to remove ticks in various steps. The trouble with the outmost is that they can be super strange values like (0.31231234) - so I had to round them and added a ~0.31 .

grafik

From these three optins I chose the third as default. - maybe we should increase the "title" fontsize or so (currently just says 1,2,3,4, but any arbitrary string can be specified there)?

@behinger
Copy link
Member Author

mh this should work. could you check if you can figure out why not?

Maybe also putting documenter on a lighter mode to not completly fail when one internal function is not documented might be a good idea too... 🤷

@behinger
Copy link
Member Author

ok docs is fixed, was simply replacing PCPTicks with UnfoldMakie.PCPTicks ..

vladdez and others added 3 commits November 30, 2023 11:25
* only formatting and docs

* formatting and desciption in tests and docs

* bug in test

* put transparency in docs

* bug fix
docs/literate/plot_results_styling.jl Outdated Show resolved Hide resolved
docs/literate/plot_results_styling.jl Outdated Show resolved Hide resolved
docs/literate/plot_results_styling.jl Outdated Show resolved Hide resolved
docs/literate/plot_results_styling.jl Outdated Show resolved Hide resolved
docs/literate/plot_results_styling.jl Outdated Show resolved Hide resolved
test/test_pcp.jl Outdated Show resolved Hide resolved
test/test_pcp.jl Outdated Show resolved Hide resolved
test/test_pcp.jl Outdated Show resolved Hide resolved
test/test_pcp.jl Outdated Show resolved Hide resolved
test/test_pcp.jl Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@behinger behinger merged commit 72b002d into main Nov 30, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants