Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_erp: layout legend_position not working #225

Closed
behinger opened this issue Aug 9, 2024 · 4 comments
Closed

plot_erp: layout legend_position not working #225

behinger opened this issue Aug 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@behinger
Copy link
Member

behinger commented Aug 9, 2024

       plot_erp!(
       f[1,1], df,mapping = (;group=:duration,color=:duration),
       categorical_color=false,
       categorical_group=true,
       layout=(;legend_position=:bottom))

I wanted to move the legend to the bottom, but it is not working, legend stays at the right side

@behinger behinger added the bug Something isn't working label Aug 9, 2024
@behinger
Copy link
Member Author

behinger commented Aug 9, 2024

this is actually also true for plot_erpimage! - havent tested others

@vladdez
Copy link
Collaborator

vladdez commented Aug 16, 2024

use legend = (; valign = :bottom,)

Why layout.legend_position even exists in examples?

@behinger
Copy link
Member Author

behinger commented Sep 2, 2024

I think this is a remnant from the FaPra students. I think what they wanted to do is to put the position of the legend and it's orientation in one command. Right now you have to do:
valign = :bottom, orientation = :horizontal

that is, provide two commands to get a better legible legend - I think we should just provide an example where we specify both and remove the legend_position confusing argument. I dont think it is worth supporting (and obv. doesnt work anyway right now)

@vladdez
Copy link
Collaborator

vladdez commented Sep 13, 2024

fixed in #237

@vladdez vladdez closed this as completed Sep 13, 2024
vladdez added a commit that referenced this issue Sep 24, 2024
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants