bugs in plot_erp

[vladdez]

m = example_data("UnfoldLinearModel")
eff_same = effects(Dict(:condition => ["levelA", "levelB"], :duration => 200), m)

plot_erp(
        eff_same;
        mapping = (; col = :eventname, color = :condition),
        axis = (; titlevisible = false,
                    xlabelvisible = false,
                    ylabelvisible = false,
                    yticklabelsvisible = false),
        layout = (; show_legend = false)
    )

problems:

• xlabelvisible = false doesn't work, while ylabelvisible works. I checked config.axis and it is correct on every step. Seems like a bug on AoG side
• layout.color = :condition gives ERROR: MethodError: no method matching isless(::Type{Any}, ::Type{Any}) on my environment, but works on Rene's.
• try first to do MWE with only AoG

AoG v0.8.0, UM v0.5.6

[ReneSkukies]

I get a different AoG version.

pkgversion(UnfoldMakie) says UM is v0.5.5, but pkgversion(UnfoldMakie.AlgebraOfGraphics) (i.e. the version that UM is using) is supposed to be v"0.6.20".

Maybe compat for AoG was updated but not the hash in the Project.toml?

[vladdez]

ah sorry I meant v0.5.6
seems something was broken in a new version, we updated AoG from 6 to 8 in UM v0.5.6

[behinger]

Try a mwe with only AoG code. I find it unlikely that this is a AoG bug. Check what the output of config.axis is right before putting it into the axis object

[ReneSkukies]

I get a different AoG version.

pkgversion(UnfoldMakie) says UM is v0.5.5, but pkgversion(UnfoldMakie.AlgebraOfGraphics) (i.e. the version that UM is using) is supposed to be v"0.6.20".

Maybe compat for AoG was updated but not the hash in the Project.toml?

Changed to newest version, now the versions are AoG v0.8.0, UM v0.5.6, but the bug still persists

[vladdez]

xlabelvisible = false doesn't work only with columns

[vladdez]

discussed here MakieOrg/AlgebraOfGraphics.jl#557