Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categorical_group = false causes error due to AoG #235

Closed
vladdez opened this issue Sep 6, 2024 · 1 comment
Closed

categorical_group = false causes error due to AoG #235

vladdez opened this issue Sep 6, 2024 · 1 comment
Assignees

Comments

@vladdez
Copy link
Collaborator

vladdez commented Sep 6, 2024

categorical_group = false gives error
ERROR: Dictionaries.IndexError("Dictionary does not contain index: group")
in

include("../docs/example_data.jl")
m = example_data("UnfoldLinearModel")
res_effects2 = effects(Dict(:condition => ["car", "face"], :continuous => -5:5), m)
plot_erp(
        res_effects2;
        mapping = (; color = :continuous, group = :continuous),
        categorical_color = false,
        categorical_group = false,
    )

So only continuous group is accepted.
I checked it and realized that in this function from AoG there is no field/index group which cause an error

function aesthetic_mapping(::Type{ScatterLines}, N::Int)
    dictionary([
        pointlike_positionals(N)...,
        :color => AesColor,
        :strokecolor => AesColor,
        :marker => AesMarker,
        :markersize => AesMarkerSize,
        :linestyle => AesLineStyle,
    ])
end

So it doesn't allow continuous groups
How to solve it?

@vladdez vladdez changed the title categorical_group = false cause error due to AoG categorical_group = false causes error due to AoG Sep 6, 2024
@vladdez
Copy link
Collaborator Author

vladdez commented Sep 12, 2024

at the end we just depreciated this argument
fixed in #237

@vladdez vladdez closed this as completed Sep 12, 2024
vladdez added a commit that referenced this issue Sep 24, 2024
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants