Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No warning that variable for col parameter in mapping has to be nonnumeric. #56

Closed
jschepers opened this issue Aug 2, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jschepers
Copy link
Collaborator

When running this code, col is just ignored because the values in the channel column are numeric. It would be nice if there was a warning/error in this case that says that the values have to be non-numeric.

plot_erp(effs;  mapping=(; y=:yhat,group= :channel,col=:channel))
@vladdez
Copy link
Collaborator

vladdez commented Mar 26, 2024

@behinger Is it fine if we just automatically convert values of :col to non-numeric?

@behinger
Copy link
Member

should be, only issue is if one puts a numeric variable with many values by accident and then receives 1000 columns :D

@vladdez vladdez added the bug Something isn't working label May 27, 2024
@vladdez
Copy link
Collaborator

vladdez commented Sep 17, 2024

fixed #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants