Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export xlsx FSP auth code (MTCN) #4527

Merged
merged 45 commits into from
Jan 16, 2025
Merged

Export xlsx FSP auth code (MTCN) #4527

merged 45 commits into from
Jan 16, 2025

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Dec 17, 2024

  • AB#225622: Payment Module - Enhancements for API-based FSPs

  • unit tests/coverage

  • AB#228316: FE changes

New Perms added: PM_DOWNLOAD_MTCN, PM_SEND_XLSX_PASSWORD

templates list from api/unicorn/payment/financialserviceproviderxlsxtemplate/
Screenshot 2025-01-15 at 2 21 49 PM
Screenshot 2025-01-15 at 2 37 40 PM

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Dec 17, 2024
@pavlo-mk pavlo-mk self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 99.41860% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (622d08f) to head (6049749).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/payment/mutations.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4527      +/-   ##
===========================================
+ Coverage    85.18%   85.26%   +0.07%     
===========================================
  Files          529      532       +3     
  Lines        36603    36700      +97     
===========================================
+ Hits         31182    31291     +109     
+ Misses        5421     5409      -12     
Flag Coverage Δ
e2e 60.77% <44.18%> (+0.01%) ⬆️
unittests 83.55% <98.25%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk changed the title WIP // Export xlsx FSP auth code WIP // Export xlsx FSP auth code (MTCN) Jan 2, 2025
@pavlo-mk pavlo-mk requested a review from saxix January 3, 2025 10:49
@mmaciekk mmaciekk self-assigned this Jan 10, 2025
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Jan 15, 2025
@pavlo-mk pavlo-mk changed the title WIP // Export xlsx FSP auth code (MTCN) Export xlsx FSP auth code (MTCN) Jan 15, 2025
@pavlo-mk pavlo-mk marked this pull request as ready for review January 15, 2025 13:29
@pavlo-mk pavlo-mk requested review from johniak and pkujawa January 15, 2025 13:30
@pavlo-mk pavlo-mk requested a review from pkujawa January 16, 2025 11:45
@pavlo-mk pavlo-mk merged commit c05d269 into develop Jan 16, 2025
13 checks passed
@pavlo-mk pavlo-mk deleted the export_xlsx_fsp_auth_code branch January 16, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants