Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16526 spec: link check spec/rfc #4044

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 11, 2024

  • run lychee action

CLDR-16526

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Sep 11, 2024
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/gh-pages.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Sep 11, 2024

https://github.com/unicode-org/cldr/actions/runs/10815398470/job/30004183744#step:11:90

Doesn't warn or error in the PR yet, but does do the run.

- run lychee action
- output summary
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/gh-pages.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Sep 11, 2024

Great!

The errors now show up in the summary page for the run: https://github.com/unicode-org/cldr/actions/runs/10816554786

@AEApple @macchiati FYI, try the link above ^

@macchiati
Copy link
Member

macchiati commented Sep 11, 2024 via email

@srl295
Copy link
Member Author

srl295 commented Sep 11, 2024

Looks great. Is it everything in docs/ ?

This one is only docs/ldml and docs/rfc but I can set up similar for site.

@macchiati
Copy link
Member

great!

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

LGTM! So are we just going to file another ticket to clean up the initial batch of problematic links?

@macchiati
Copy link
Member

macchiati commented Sep 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants