ICU-22994 Remove misuage of Calendar::getType #3310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use getDynamicClassID and getStaticClassID for calendar type comparision instead of strcmp.
Hide some Hebrew adjustment by using rencently added Calendar API.
dynamic_cast will not work because dynamic_cast(superclass) will not return nullptr for a subclass. For example, ISO8601Calendar is a subclass of GregorianCalendar
and if we have a cal, which could be either a GregorianCalendar or ISO8601Calendar, we cannot depend on dynamic_cast<GregorianCalendar*>(cal) != nullptr to check getType will return “gregorian”
Checklist