icu4x_custom_data is not configured when ICU4X_DATA_DIR is set

[ghost]

It seems like icu4x_custom_data would be set if the environment variable ICU4X_DATA_DIR is set:

icu4x/provider/baked/datetime/build.rs

Line 7 in 3c47d82

println!("cargo:rustc-cfg=icu4x_custom_data");

But from my recent compilation of the code (Cargo.toml and logs attached), I had to manually set the flag for ICU4X_DATA_DIR to take effect. I wonder what could be wrong.

My build command:

ICU4X_DATA_DIR=$(pwd)/my_data cargo +nightly rustc -Z build-std=core,alloc,panic_abort -Z build-std-features=panic_immediate_abort --release -p icu_capi --crate-type staticlib --target thumbv7em-none-eabihf -vv

Cargo.toml.txt
build.log.txt

[Manishearth]

I'm unable to reproduce this.

On main, running $ ICU4X_DATA_DIR=~/sand/tmpicu cargo +nightly rustc -Z build-std=core,alloc,panic_abort -Z build-std-features=panic_immediate_abort --release -p icu_capi --crate-type staticlib --target thumbv7em-none-eabihf -vv --no-default-features from ffi/capi (which ought to be equivalent)

     Running `CARGO=/home/manishearth/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo CARGO_CRATE_NAME=icu_locale_data CARGO_MANIFEST_DIR=/home/manishearth/dev/icu4x/provider/data/locale CARGO_PKG_AUTHORS='The ICU4X Project Developers' CARGO_PKG_DESCRIPTION='Data for the icu_locale crate' CARGO_PKG_HOMEPAGE='https://icu4x.unicode.org' CARGO_PKG_LICENSE=Unicode-3.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=icu_locale_data CARGO_PKG_README=README.md CARGO_PKG_REPOSITORY='https://github.com/unicode-org/icu4x' CARGO_PKG_RUST_VERSION=1.70 CARGO_PKG_VERSION=1.5.0 CARGO_PKG_VERSION_MAJOR=1 CARGO_PKG_VERSION_MINOR=5 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' CARGO_RUSTC_CURRENT_DIR=/home/manishearth/dev/icu4x LD_LIBRARY_PATH='/home/manishearth/dev/icu4x/target/release/deps:/home/manishearth/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib' OUT_DIR=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/build/icu_locale_data-6ab655b27c5cb145/out /home/manishearth/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc --crate-name icu_locale_data --edition=2021 provider/data/locale/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=103 --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no --warn=unexpected_cfgs --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' --check-cfg 'cfg(icu4x_custom_data)' -C metadata=90a7d17bf86cef84 -C extra-filename=-90a7d17bf86cef84 --out-dir /home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps --target thumbv7em-none-eabihf -C strip=debuginfo -L dependency=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps -L dependency=/home/manishearth/dev/icu4x/target/release/deps --extern 'noprelude:alloc=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps/liballoc-a9f85b7760d97de5.rmeta' --extern 'noprelude:compiler_builtins=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps/libcompiler_builtins-34cdac14f89f1f81.rmeta' --extern 'noprelude:core=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps/libcore-a8c9f9e8066fff3b.rmeta' --extern icu_provider_baked=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps/libicu_provider_baked-2bc4ec26c4cb950e.rmeta --extern 'noprelude:panic_abort=/home/manishearth/dev/icu4x/target/thumbv7em-none-eabihf/release/deps/libpanic_abort-ecc2a62326637496.rmeta' -Z unstable-options --cfg icu4x_custom_data --check-cfg 'cfg(icu4c_enable_renaming)'`
error: couldn't read /home/manishearth/sand/tmpicu/mod.rs: No such file or directory (os error 2)
  --> provider/data/locale/src/lib.rs:15:1
   |
15 | include!(concat!(core::env!("ICU4X_DATA_DIR"), "/mod.rs"));
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

(the error is expected, there's nothing in that folder)

[Manishearth]

Is there some other build system involved?

[ghost]

Hm I wasn't able to reproduce this on main, either. I don't think any other build system is involved.