Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZeroTrie: Make plain ASCII and Ignore Case have same representation #5584

Open
sffc opened this issue Sep 24, 2024 · 0 comments
Open

ZeroTrie: Make plain ASCII and Ignore Case have same representation #5584

sffc opened this issue Sep 24, 2024 · 0 comments
Labels
C-unicode Component: Props, sets, tries T-enhancement Type: Nice-to-have but not required

Comments

@sffc
Copy link
Member

sffc commented Sep 24, 2024

Currently they have different representations due to how they order strings. However, this is trivial to fix at runtime by writing a custom comparator in the binary search. Making them have the same representation would make it easier to swap between the two representations in the future without breaking data.
@sffc sffc added T-enhancement Type: Nice-to-have but not required C-unicode Component: Props, sets, tries labels Sep 24, 2024
@sffc sffc mentioned this issue Sep 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-unicode Component: Props, sets, tries T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sffc