Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should NeoFormatter and TypedNeoFormatter have default generics? #5687

Open
sffc opened this issue Oct 15, 2024 · 0 comments
Open

Should NeoFormatter and TypedNeoFormatter have default generics? #5687

sffc opened this issue Oct 15, 2024 · 0 comments
Labels
discuss-priority Discuss at the next ICU4X meeting
Milestone
ICU4X 2.0 ⟨P1⟩

Comments

@sffc
Copy link
Member

sffc commented Oct 15, 2024

Currently if you want a time formatter you need to explicitly set the calendar type to NeverCalendar / ().

This raises the general question, should they have default generics?

The time formatter specific concern can also be addressed by

  1. Make a type alias such as pub type TimeFormatter
  2. Make format_time imply this bound

@Manishearth @robertbastian
@sffc sffc added the discuss-priority Discuss at the next ICU4X meeting label Oct 15, 2024
@sffc sffc added this to the ICU4X 2.0 ⟨P1⟩ milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss-priority Discuss at the next ICU4X meeting
Projects
None yet
Milestone
ICU4X 2.0 ⟨P1⟩
Development

No branches or pull requests
1 participant
@sffc