Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concept: internal metazone lookup #5535

Closed
wants to merge 1 commit into from
Closed

Concept: internal metazone lookup #5535

wants to merge 1 commit into from

Conversation

robertbastian
Copy link
Member

No description provided.

@robertbastian robertbastian mentioned this pull request Sep 12, 2024
Open
sffc
sffc requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, it should be implemented similar to WeekDataV1Marker, since it is a cross-crate data marker.

But let's decide in #5533 first.

@robertbastian
Copy link
Member Author

Of course if we do this we'll do this cleanly, without adding timezone data on datetime's baked provider. This is just a proof of concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc requested changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki will be requested when the pull request is marked ready for review zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @sffc