Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SegmenterCldr.txt #947

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Remove SegmenterCldr.txt #947

merged 5 commits into from
Oct 14, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 9, 2024

Back in March I had written:

Right now the 15.1 line breaking rules in SegmenterCldr.txt are used by no-one, and this is a good thing since they are wrong and untested (and we went through a release with these wrong rules!). Let’s get rid of that quasi-copy before someone gets hurt.

And then I forgot to do anything. They are still wrong, and they have not been updated for 16.0. Let’s get rid of those.

macchiati
macchiati previously approved these changes Oct 9, 2024
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should remove the whole mechanism, because we may need it back in the future. Once we settle on overrides with "character x behaves like character y", I'd be comfortable removing.

@eggrobin
Copy link
Member Author

We discussed that earlier: #492 (comment).
Right now this is not used, and if it had been used it would have produced garbage, most likely without anyone noticing, so it is a footgun: we really should remove SegmenterCldr.txt before someone gets hurt.
When it comes to the code itself, I am removing the minimum needed to make CI pass; if we ever want to bring back a SegmenterCldr this is trivial to revert (that is why we have source control!).

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense

@eggrobin eggrobin merged commit 4af5343 into unicode-org:main Oct 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants