Skip to content

Commit

Permalink
I've Got The Power (#132)
Browse files Browse the repository at this point in the history
Use the most EPIC control plane nodes possible, as opposed to being a
penny pincher, so etcd etc doesn't melt under any circumstances.
Working, at a cost, is always preferable to battling support requests.
  • Loading branch information
spjmurray authored Oct 4, 2024
1 parent 90e904c commit 02be2bb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions charts/kubernetes/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ description: A Helm chart for deploying Unikorn Kubernetes Service

type: application

version: v0.2.40
appVersion: v0.2.40
version: v0.2.41
appVersion: v0.2.41

icon: https://raw.githubusercontent.com/unikorn-cloud/assets/main/images/logos/dark-on-light/icon.png

Expand Down
6 changes: 3 additions & 3 deletions pkg/server/handler/cluster/conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,8 @@ func (g *generator) defaultApplicationBundle(ctx context.Context) (*unikornv1.Ku
}

// defaultControlPlaneFlavor returns a default control plane flavor. This will be
// one that doesxn't have any GPUs. The provider ensures the "nost cost-effective"
// one that doesxn't have any GPUs. The provider ensures the "most cost-effective"
// comes first.
// TODO: we should allow this to be configured per region.
func (g *generator) defaultControlPlaneFlavor(ctx context.Context, request *openapi.KubernetesClusterWrite) (*regionapi.Flavor, error) {
resp, err := g.region.GetApiV1OrganizationsOrganizationIDRegionsRegionIDFlavorsWithResponse(ctx, g.organizationID, request.Spec.RegionId)
if err != nil {
Expand All @@ -204,7 +203,8 @@ func (g *generator) defaultControlPlaneFlavor(ctx context.Context, request *open
return nil, errors.OAuth2ServerError("unable to select a control plane flavor")
}

return &flavors[0], nil
// Pick the most "epic" flavor possible, things tend to melt if you are too stingy.
return &flavors[len(flavors)-1], nil
}

// defaultImage returns a default image for either control planes or workload pools
Expand Down

0 comments on commit 02be2bb

Please sign in to comment.