Preserve Defaulted Values #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed I can alter a cluster's flavor and scaling and it's retained across an update call. |
The Kubernetes Server defaults a bunch of fields where we don't really want to expose all that complexity to the end user, but require it in the custom resource e.g. images etc. Problem is, the defaults change, and that will randomly trigger updates which isn't great. There are also hard coded values e.g. the control plane replicas, and you as an admin may want to scale that to 5, 7 etc. to support a specific weird workload, and obviously don't want that value reverted on an update. Long story short, if it's defaulted, preserve what's there all ready if we can, otherwise generate from the defaults.
spjmurray
force-pushed
the
preserve_to_serve
branch
from
03f4087
to
fcdf558
Compare
spjmurray
added a commit
that referenced
this pull request
Oct 15, 2024
The Kubernetes Server defaults a bunch of fields where we don't really want to expose all that complexity to the end user, but require it in the custom resource e.g. images etc. Problem is, the defaults change, and that will randomly trigger updates which isn't great. There are also hard coded values e.g. the control plane replicas, and you as an admin may want to scale that to 5, 7 etc. to support a specific weird workload, and obviously don't want that value reverted on an update. Long story short, if it's defaulted, preserve what's there all ready if we can, otherwise generate from the defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes Server defaults a bunch of fields where we don't really want to expose all that complexity to the end user, but require it in the custom resource e.g. images etc. Problem is, the defaults change, and that will randomly trigger updates which isn't great. There are also hard coded values e.g. the control plane replicas, and you as an admin may want to scale that to 5, 7 etc. to support a specific weird workload, and obviously don't want that value reverted on an update. Long story short, if it's defaulted, preserve what's there all ready if we can, otherwise generate from the defaults.