Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _member_ Role #55

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Remove _member_ Role #55

merged 1 commit into from
Apr 22, 2024

Conversation

spjmurray
Copy link
Member

@spjmurray spjmurray commented Apr 22, 2024

This is a legacy thing apparently, and must get covered by either member or be implicit. However, life. Seems our provider requires it for now, so just use an explicit list if provided to remove a TODO.

@spjmurray spjmurray force-pushed the remove_member branch 2 times, most recently from 6460c74 to 698a4dc Compare April 22, 2024 13:48
@spjmurray spjmurray marked this pull request as ready for review April 22, 2024 13:49
This is a legacy thing apparently, and must get covered by either
`member` or be implicit.  However, life.  Seems our provider requires it
for now, so just use an explicit list if provided to remove a TODO.
@spjmurray
Copy link
Member Author

Looks to provision correctly, lock S-foils in attack positions...

@spjmurray spjmurray merged commit 2e98dd0 into main Apr 22, 2024
2 checks passed
@spjmurray spjmurray deleted the remove_member branch April 22, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant