Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Projects Explicit #6

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Make Projects Explicit #6

merged 1 commit into from
Feb 29, 2024

Conversation

spjmurray
Copy link
Member

With organizations being the top level thing now we need to make this implicitly spring into existence when a project is created. Projects are no longer implicitly created, and need to be invoked from a client. Projects are also now namespace scoped (to the organization).

With organizations being the top level thing now we need to make this
implicitly spring into existence when a project is created.  Projects
are no longer implicitly created, and need to be invoked from a client.
Projects are also now namespace scoped (to the organization).
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 35.05%. Comparing base (d33df86) to head (2af51a3).

Files Patch % Lines
pkg/apis/unikorn/v1alpha1/helpers.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   35.26%   35.05%   -0.21%     
==========================================
  Files           4        4              
  Lines         346      348       +2     
==========================================
  Hits          122      122              
- Misses        217      219       +2     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spjmurray spjmurray merged commit c912b96 into main Feb 29, 2024
2 of 4 checks passed
@spjmurray spjmurray deleted the explicit_projects branch February 29, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant