Add Security Group CRD #65
Open
+629
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sricardor/region into feature/add-security-group-crd
spjmurray
requested changes
Oct 22, 2024
| // SecurityGroupID is the security group ID. | ||
| SecurityGroupID *string `json:"securityGroupID,omitempty"` | ||
| // Rules are the security group rules. | ||
| Rules []rules.SecGroupRule `json:"rules,omitempty"` |
There was a problem hiding this comment.
I don't think we should be importing/exposing gophercloud types, there's jsut way too much unnecessary crap in there.
There was a problem hiding this comment.
😮 I updated it but forgot to push. The gophercloud type is missing the JSON tag on a few elements, which is causing the CRD generation to fail. I'll fix that - thanks for the review so far! ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the SecurityGroup CRD and the provider-specific data structure