Skip to content

Commit

Permalink
fix: Remove _app.tsx's next SEO as this produces duplicate entries
Browse files Browse the repository at this point in the history
This fix removes the injection of the "default SEO" which is already
handled by the internal `<SEO />` component.

Signed-off-by: Alexander Jung <alex@unikraft.io>
  • Loading branch information
nderjung committed Jun 24, 2024
1 parent 0a29b8d commit 8969a45
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
5 changes: 0 additions & 5 deletions pages/_app.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
import { ChakraProvider } from '@chakra-ui/react'
import { DefaultSeo } from 'next-seo'
import Head from 'next/head'
import React from 'react'
import FontFace from 'components/font-face'
import theme from 'theme'
import { getSeo } from 'utils/seo'
import '../src/global.css' // TODO(nderjung): Non-relative path.
import 'asciinema-player/dist/bundle/asciinema-player.css'
import 'components/asciinema-player.css'

const App = ({ Component, pageProps }) => {
const seo = getSeo()

return (
<>
<Head>
Expand All @@ -26,7 +22,6 @@ const App = ({ Component, pageProps }) => {
<meta name="msapplication-TileColor" content="#032b59" />
<link rel="manifest" href="/site.webmanifest" />
</Head>
<DefaultSeo {...seo} />
<ChakraProvider theme={theme}>
<Component {...pageProps} />
</ChakraProvider>
Expand Down
9 changes: 7 additions & 2 deletions src/components/landing-hero.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ import CodeContainer from 'components/mdx-components/codeblock/code-container'
import CopyButton from 'components/mdx-components/codeblock/copy-button'
import { t } from 'utils/i18n'

const announce = {
title: 'Unikraft Summer Workshop 2024',
href: '/hackathons/usw24',
}

export default function LandingHero() {
const getKraftKit = 'curl -sSfL https://get.kraftkit.sh | sh'

Expand Down Expand Up @@ -69,7 +74,7 @@ export default function LandingHero() {
p='2'
pr='4'
>
<NextLink href={'/blog/2024-06-07-unikraft-releases-v0.17.0'} passHref>
<NextLink href={announce.href} passHref>
<chakra.a
as={Box}
role={'group'}
Expand Down Expand Up @@ -111,7 +116,7 @@ export default function LandingHero() {
textDecoration: 'underline'
}}
>
Unikraft releases 0.17.0 (Calypso)
{announce.title}
</Text>
<Box
display={{
Expand Down

0 comments on commit 8969a45

Please sign in to comment.