Implement minimal built-in checks for Ibis backend #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
* Restore accidentally-deleted use of "breakpoint()" Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Swap `types-pkg_resources` with `types-setuptools` (unionai-oss#1779) * Swap `types-pkg_resources` with `types-setuptools` Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update the expected error message to name variable Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Fix expected outputs for pandas-stubs 2.2.2.240807 Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Update CI configuration to filter right pandas ver Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Do not test Ibis below py3.9, add DuckDB for tests Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
* Test model schema equivalency with optional dtypes Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Support specifying and validating optional columns Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Add DuckDB for testing and regenerate requirements Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
* Implement minimal `coerce` and corresponding tests Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Do not exclude 3.9 in Ibis CI, and regenerate reqs Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
* [wip] add minimal ibis check backend implementation Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * support scalar, column, and table check output types Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * support scalar, column, and table check output types Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * Ibis check backend suggestions (unionai-oss#1855) * Apply suggestions from code review Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * Fix row-order-dependent order by adding table cols Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * fix lint Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> * fix unit tests Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> --------- Signed-off-by: cosmicBboy <niels.bantilan@gmail.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
===========================================
- Coverage 94.28% 73.45% -20.83%
===========================================
Files 91 134 +43
Lines 7013 9721 +2708
===========================================
+ Hits 6612 7141 +529
- Misses 401 2580 +2179 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base should be the updated
ibis-devfrom #1884