-
Notifications
You must be signed in to change notification settings - Fork 271
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #5292 from sellout/delayed-int-roundtrip
Add a transcript to show that #4711 has been fixed
- Loading branch information
Showing
2 changed files
with
76 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Delayed Int literal doesn't round trip | ||
|
||
```ucm:hide | ||
scratch/main> builtins.merge | ||
``` | ||
|
||
```unison | ||
thisWorks = '(+1) | ||
thisDoesNotWork = ['(+1)] | ||
``` | ||
|
||
Since this is fixed, `thisDoesNotWork` now does work. | ||
|
||
```ucm | ||
scratch/main> add | ||
scratch/main> edit thisWorks thisDoesNotWork | ||
scratch/main> load | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# Delayed Int literal doesn't round trip | ||
|
||
``` unison | ||
thisWorks = '(+1) | ||
thisDoesNotWork = ['(+1)] | ||
``` | ||
|
||
``` ucm | ||
Loading changes detected in scratch.u. | ||
I found and typechecked these definitions in scratch.u. If you | ||
do an `add` or `update`, here's how your codebase would | ||
change: | ||
⍟ These new definitions are ok to `add`: | ||
thisDoesNotWork : ['{g} Int] | ||
thisWorks : 'Int | ||
``` | ||
Since this is fixed, `thisDoesNotWork` now does work. | ||
|
||
``` ucm | ||
scratch/main> add | ||
⍟ I've added these definitions: | ||
thisDoesNotWork : ['{g} Int] | ||
thisWorks : 'Int | ||
scratch/main> edit thisWorks thisDoesNotWork | ||
☝️ | ||
I added 2 definitions to the top of scratch.u | ||
You can edit them there, then run `update` to replace the | ||
definitions currently in this namespace. | ||
scratch/main> load | ||
Loading changes detected in scratch.u. | ||
I found and typechecked the definitions in scratch.u. This | ||
file has been previously added to the codebase. | ||
``` | ||
``` unison:added-by-ucm scratch.u | ||
thisDoesNotWork : ['{g} Int] | ||
thisDoesNotWork = [do +1] | ||
thisWorks : 'Int | ||
thisWorks = do +1 | ||
``` | ||
|