Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@source{Stream.emit} gives the wrong error message #5178

Open
stew opened this issue Jul 3, 2024 · 2 comments · May be fixed by #5263
Open

@source{Stream.emit} gives the wrong error message #5178

stew opened this issue Jul 3, 2024 · 2 comments · May be fixed by #5263
Labels
error-message Request for improved error message

Comments

@stew
Copy link
Member

stew commented Jul 3, 2024

What's the message you're seeing?

      -- The name #rfi1v9429f is assigned to the reference ShortHash {prefix
      =
      "rfi1v9429f9qluv533l2iba77aadttilrpmnhljfapfnfa6sru2nr8ibpqvib9nc4s4nb9s1as45upsfqfqe6ivqi2p82b2vd866it8",
      cycle = Nothing, cid = Nothing}, which is missing from the codebase.
      Tip: You might need to repair the codebase manually.

What would a better version look like?

Stream.emit is an ability member, not a term.

Environment (please complete the following information):

  • unison version: 335512e (built on 2024-06-11)
  • OS/Architecture: debian 12 / amd64
@stew stew added the error-message Request for improved error message label Jul 3, 2024
@aryairani
Copy link
Contributor

😬
I need to amend the template to ask for more context

@stew
Copy link
Member Author

stew commented Jul 4, 2024

input:

```unison
foo = {{
@source{Stream.emit}
}}
```

output:

      -- The name #rfi1v9429f is assigned to the reference ShortHash {prefix
      =
      "rfi1v9429f9qluv533l2iba77aadttilrpmnhljfapfnfa6sru2nr8ibpqvib9nc4s4nb9s1as45upsfqfqe6ivqi2p82b2vd866it8",
      cycle = Nothing, cid = Nothing}, which is missing from the codebase.
      Tip: You might need to repair the codebase manually.

@aryairani aryairani added crash and removed crash labels Jul 4, 2024
sellout added a commit to sellout/unison that referenced this issue Aug 2, 2024
`@source{some ability member}` now shows the source of the ability.

Fixes unisonweb#5178.
@sellout sellout linked a pull request Aug 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error-message Request for improved error message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants