Provide mechanism for hashing BranchFormatFull #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
commented
Aug 12, 2023
| @@ -1,6 +1,41 @@ | |||
| {-# LANGUAGE RecordWildCards #-} | |||
|
|
|||
| module U.Codebase.Sqlite.Serialization where | |||
| module U.Codebase.Sqlite.Serialization | |||
| ( decomposeBranchFormat, | |||
There was a problem hiding this comment.
Added an export list for my own sanity of scanning what the module contains.
I generalized some combinators in this module as I was iterating on it, ended up that the only thing I needed was to pull out getLocalBranch to a top-level-definition and export that. I could re-specialize the parsers, but the generalized versions may come in handy in the future.
ChrisPenner
commented
Aug 12, 2023
| @@ -2,6 +2,10 @@ module U.Codebase.HashTags where | |||
|
|
|||
| import Unison.Hash (Hash) | |||
|
|
|||
| -- | Represents a hash of a type or term component | |||
| newtype ComponentHash = ComponentHash {unComponentHash :: Hash} | |||
There was a problem hiding this comment.
I'm surprised we didn't have a tag for this already, there are a lot of spots we should likely be using it. I added something like this into Enlil for my pg name-lookup stuff, but it should really just be part of unison core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pre-req for https://github.com/unisoncomputing/enlil/pull/314;
Generalizes how we deserialize BranchFormat's so I can deserialize entities from the Temp/Sync entity formats BEFORE saving them into the codebase (i.e. before we have object or db IDs)
This will allow Share to correctly validate hashes on branches before storing them into a user's codebase.
Implementation notes
hashBranchFormatFullto HashHandle which produces a hash for a LocalBranch if provided hash references in a local ID mappinghashBranchFormatToH2Branch :: Memory.BranchFull.HashBranch -> HashingV2.Branchinternally to facilitate hashing branch formats.ComponentHashhash tag for hashes used in references/referentsInteresting/controversial decisions
Include anything that you thought twice about, debated, chose arbitrarily, etc.
What could have been done differently, but wasn't? And why?
Test coverage
Tested locally as part of https://github.com/unisoncomputing/enlil/pull/314;