Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transcript with edit.namespace output for base and http #5361

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

aryairani
Copy link
Contributor

Overview

A place to notice pretty-printing changes.

Implementation notes

Interesting/controversial decisions

  • It takes a while to run, we may want to split them out into a different test that utilizes some codebase caching.
  • It produces big output which may clog Github Actions log viewing.
  • It doesn't try to round-trip them, as they would both fail.
  • It's pinned to specific releases to avoid spurious output changes

Test coverage

Loose ends

Especially the caching thing.

@aryairani
Copy link
Contributor Author

It adds to the transcript running time (especially with the clone) but I figure it's better to get it in first, so we can spot how changes affect the output, and speed it up later.

@aryairani
Copy link
Contributor Author

Windows showing a change to the golden transcripts in http output, not sure why yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants