Ensure units are all created with matching tags #5534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Values which should have been equal would be reported as non-equal WHEN:
()
()
and the other came from a builtinAny
when they were being comparedUniversal.eq
The reason is that unit values were created with
PackedTag 0
in some locations andunitTag
in others;the difference was only surfaced when wrapped in
Any
because universal equality withinAny
checks type tags.Implementation notes
unitTag
for all units regardless where they come from.PackedTag 0
for the pure effects case.Test coverage
Ran all the base tests.