feat: better readability for characters in admin view #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fogapod
reviewed
Sep 21, 2024
src/persistence/management/commands/nuke_duplicated_characters.py
Outdated
Show resolved
Hide resolved
src/persistence/management/commands/nuke_duplicated_characters.py
Outdated
Show resolved
Hide resolved
src/persistence/management/commands/nuke_duplicated_characters.py
Outdated
Show resolved
Hide resolved
corp-0
force-pushed
the
character-improvements
branch
from
30358ce
to
6875b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first, a little correction that changes the field in users for the one that will actually grant them access to admin view.
Second, added the name of the character and last_updated fields to Character's admin view. Now instead of just saying "Gilles's character", it will say the character name and who created it.
I also added a command to fucking nuke all duplicated characters hoarding space in the database (it includes a unit test, so it should be sorta safe to just run in prod, maybe)