readtags: refactor for searching multiple tag files #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The original code called findTag or listTags directly in the process of command line parsing. This change introduces new data structure named actionSpec. During parsing command line, readtags builds an actionSpec. After parsing readtags takes an action based on the actionSpec. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…putSpec Signed-off-by: Masatake YAMATO <yamato@redhat.com>
… the canonWorkArea Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4074 +/- ##
==========================================
+ Coverage 85.51% 85.60% +0.08%
==========================================
Files 237 237
Lines 57030 57066 +36
==========================================
+ Hits 48769 48849 +80
+ Misses 8261 8217 -44 ☔ View full report in Codecov by Sentry. |
|
I should add more test cases. |
masatake
force-pushed
the
readtags-refactor-for-searching-multiple-tag-files
branch
2 times, most recently
from
37e7456
to
e86284f
Compare
…ing tag file Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
readtags-refactor-for-searching-multiple-tag-files
branch
from
e86284f
to
c848373
Compare
…ng actions Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.