Skip to content

fix(joinRelativeURL): handle base with protocol #840

fix(joinRelativeURL): handle base with protocol

fix(joinRelativeURL): handle base with protocol #840

Triggered via pull request March 15, 2024 22:44
@pi0pi0
synchronize #222
fix/relative-join
Status Failure
Total duration 36s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 1 warning
test/join.test.ts > joinURL > joinURL("https://google.com/", "../foo") === "https://google.com/foo": test/join.test.ts#L32
AssertionError: expected 'https://google.com/../foo' to be 'https://google.com/foo' // Object.is equality - Expected + Received - https://google.com/foo + https://google.com/../foo ❯ test/join.test.ts:32:46
test/join.test.ts > joinRelativeURL > joinRelativeURL("https://google.com/", "../foo") === "https://google.com/foo": test/join.test.ts#L57
AssertionError: expected 'foo' to be 'https://google.com/foo' // Object.is equality - Expected + Received - https://google.com/foo + foo ❯ test/join.test.ts:57:57
ci
Process completed with exit code 1.
ci
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.