fix(encodeQueryValue): encode the slash character (#198)

unjs · Feb 5, 2024 · 47f4070 · 47f4070
1 parent dcf926e
commit 47f4070
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/encoding.ts b/src/encoding.ts
@@ -61,6 +61,7 @@ export function encodeQueryValue(input: QueryValue): string {
       .replace(AMPERSAND_RE, "%26")
       .replace(ENC_BACKTICK_RE, "`")
       .replace(ENC_CARET_RE, "^")
+      .replace(SLASH_RE, "%2F")
   );
 }
 

diff --git a/test/encoding.test.ts b/test/encoding.test.ts
@@ -95,7 +95,7 @@ describe("encodeQueryValue", () => {
     },
     {
       input: "!@#$%^&*()_+{}[]|\\:;<>,./?",
-      out: "!@%23$%25^%26*()_%2B%7B%7D%5B%5D|%5C:;%3C%3E,./?",
+      out: "!@%23$%25^%26*()_%2B%7B%7D%5B%5D|%5C:;%3C%3E,.%2F?",
     },
   ];
 

diff --git a/test/normalize.test.ts b/test/normalize.test.ts
@@ -30,8 +30,8 @@ describe("normalizeURL", () => {
     "/http:/": "/http:/",
     "http://[2001:db8:85a3:8d3:1319:8a2e:370:7348]/":
       "http://[2001:db8:85a3:8d3:1319:8a2e:370:7348]/",
-    "http://localhost/?redirect=http://google.com?q=test":
-      "http://localhost/?redirect=http://google.com?q=test",
+    "http://localhost/?redirect=http:%2F%2Fgoogle.com?q=test":
+      "http://localhost/?redirect=http:%2F%2Fgoogle.com?q=test",
     "http://localhost/?email=some+v1@email.com":
       "http://localhost/?email=some+v1@email.com",
     "http://localhost/?email=some%2Bv1%40email.com":