Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add the tests for $URL #197

Merged
merged 2 commits into from
Feb 5, 2024
Merged

tests: add the tests for $URL #197

merged 2 commits into from
Feb 5, 2024

Conversation

divine
Copy link
Contributor

@divine divine commented Dec 14, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add the tests for $URL

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

test/url.test.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c11fdf7) 95.27% compared to head (2264add) 98.38%.
Report is 11 commits behind head on main.

❗ Current head 2264add differs from pull request most recent head 69c9650. Consider uploading reports for the commit 69c9650 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   95.27%   98.38%   +3.11%     
==========================================
  Files           7        7              
  Lines         867      867              
  Branches      187      200      +13     
==========================================
+ Hits          826      853      +27     
+ Misses         41       14      -27     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@pi0 pi0 changed the title chore: add the tests for $URL tests: add the tests for $URL Feb 5, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 7a4148c into unjs:main Feb 5, 2024
2 checks passed
@divine divine deleted the coverage-up-to branch February 8, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants