Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: presets meta #374

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: presets meta #374

merged 2 commits into from
Dec 12, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Dec 11, 2024

This PR adds meta to the presets which is useful for external presets meta.

Presets are exposed from defineEnv for inspection and path is useful for #373

@pi0 pi0 self-assigned this Dec 11, 2024
@pi0 pi0 requested a review from a team as a code owner December 11, 2024 18:49
@pi0 pi0 requested a review from vicb December 11, 2024 18:49
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments/questions

@@ -15,6 +15,7 @@ import nodeCompatPreset from "./presets/nodeless";
*/
export function defineEnv(opts: CreateEnvOptions = {}): {
env: Environment;
presets: Preset[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update l10 above with presets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to undrestand, L10 is part of example code:

image

src/presets/nodeless.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/presets/nodeless.ts Show resolved Hide resolved
src/env.ts Show resolved Hide resolved
@pi0 pi0 merged commit ec0747a into main Dec 12, 2024
2 checks passed
@vicb vicb deleted the feat/preset-meta branch December 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants