catch expiration bug (#677)

* fix: add logs and catch error

* ci.yaml: remove unnecessary steps in the CI workflow

service.ts: remove unnecessary try-catch block for checking key expiration

* fix(service.ts): fix expiration check for keys with serialized date strings in zone cache

* fix(service.ts): fix typo in comment, change "the" to "them"

apps/api/src/pkg/keys/service.ts

@@ -160,8 +160,12 @@ export class KeyService {
     /**
      * Expiration
      */
-    if (data.key.expires && data.key.expires.getTime() < Date.now()) {
-      return result.success({ valid: false, code: "NOT_FOUND" });
+    if (data.key.expires) {
+      // The zone cache can not deserialize dates and returns them as string, so we need to do it manually
+      const expires = new Date(data.key.expires).getTime();
+      if (expires < Date.now()) {
+        return result.success({ valid: false, code: "NOT_FOUND" });
+      }
     }
 
     if (data.api.ipWhitelist) {
@@ -178,7 +182,6 @@ export class KeyService {
     /**
      * Ratelimiting
      */
-
     const [pass, ratelimit] = await this.ratelimit(c, data.key);
     if (!pass) {
       return result.success({