Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: auth interface #2136

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor: auth interface #2136

wants to merge 5 commits into from

Conversation

chronark
Copy link
Collaborator

  • wip
  • wip
  • wip

@chronark
wip
9bb866f
@chronark
Merge branch 'main' of https://github.com/unkeyed/unkey into auth-int…
6cb300e 
…erface
@chronark
wip
60fddf5
@chronark
chore(app): remove unused files related to breadcrumb and gateway cre…
940d715 
…ation

chore(monitors): remove unused files create-new-button.tsx, loading.tsx,
and page.tsx

chore(secrets): remove unused form, page, and secrets components

chore(webhooks): remove unused delete-webhook.tsx, duration.tsx, and page.tsx files

chore(webhooks): remove unused files and components from the project

fix(page.tsx): rename ingestAuditLogs function to ingestAuditLogsTinybird
feat(page.tsx): add insertAuditLogs function to handle audit log insertion
feat(index.ts): add insertAuditLogs function to handle audit log insertion
feat(tinybird.ts): rename ingestAuditLogs function to ingestAuditLogsTinybird
feat(create.ts): use insertAuditLogs function to handle audit log insertion
feat(delete.ts): use insertAuditLogs function to handle audit log insertion

fix(api): update function names to match new file structure
feat(api): add support for inserting audit logs in update functions

refactor(routers): remove unused imports and functions
feat(key): add audit logs for key creation and deletion
feat(rootKey): add audit logs for root key creation and deletion

fix(key): update import of ingestAuditLogs to ingestAuditLogsTinybird
feat(key): add insertAuditLogs function call to updateKeyEnabled, updateKeyExpiration, updateKeyMetadata, updateKeyName, and updateKeyOwnerId functions

fix(updateRatelimit.ts): update function names for audit logs and tinybird
feat(updateRatelimit.ts): add support for inserting audit logs and using
transaction for database updates
fix(updateRemaining.ts): update function names for audit logs and tinybird
feat(updateRemaining.ts): add support for inserting audit logs and using
transaction for database updates
fix(updateRootKeyName.ts): update function names for audit logs and tinybird
feat(updateRootKeyName.ts): add support for inserting audit logs and using
transaction for database updates

fix(llmGateway): update import statement for ingestAuditLogs function
fix(llmGateway): update function call to ingestAuditLogsTinybird
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(llmGateway): refactor transaction block to include insertAuditLogs call
fix(ll

fix(ratelimit): update function names and imports for audit logs
feat(ratelimit): add support for inserting audit logs in database and Tinybird

fix(rbac.ts): update import paths for audit related functions
fix(rbac.ts): change db operations to use transactions for atomicity
feat(rbac.ts): add support for inserting audit logs in db transactions
feat(rbac.ts): add support for inserting audit logs in Tinybird for rbac actions

refactor(rbac.ts): refactor update and delete permission methods to use
database transactions and add audit log entries for each operation

fix(rbac): update function names for audit logs and transaction handling
feat(rbac): add audit logs for permission, role, and key connections

fix(rbac): update import statements for audit logs functions
feat(rbac): add support for inserting audit logs in transactional operations
feat(rbac): use separate function for audit logs insertion in tinybird
feat(rbac): add support for connecting and disconnecting roles and permissions

fix(rbac): update function names and imports for audit logs
feat(rbac): add audit logs for disconnecting role from key and permission from root key
feat(rbac): add audit logs for updating permission and role
feat(rbac): add audit logs for upserting permission

chore(secrets): remove create, decrypt, and update secret routers

fix(vercel.ts): update function name from ingestAuditLogs to insertAuditLogs
fix(vercel.ts): update function name from ingestAuditLogs to ingestAuditLogsTinybird
feat(vercel.ts): add support for inserting audit logs using insertAuditLogs
feat(vercel.ts): add support for inserting audit logs using ingestAuditLogsTinybird

fix(webhook): remove unused import statements
fix(webhook): remove unused delete and toggle webhook router files
fix(workspace): change function name from ingestAuditLogs to insertAuditLogs
fix(workspace): change function name from ingestAuditLogs to ingestAuditLogsTinybird

fix(workspace): change function name from ingestAuditLogs to ingestAuditLogsTinybird
feat(workspace): add insertAuditLogs function for audit logging in changePlan.ts
feat(workspace): add insertAuditLogs function for audit logging in create.ts
feat(workspace): add insertAuditLogs function for audit logging in optIntoBeta.ts
@chronark
wip
303724a
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 303724a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ❌ Failed (Inspect) Sep 26, 2024 4:21pm
planetfall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 4:21pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 4:21pm
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 4:21pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 4:21pm

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 26, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@chronark chronark changed the title auth interface refactor: auth interface Sep 26, 2024
@chronark
Copy link
Collaborator Author

For @mcstepp next week, maybe a good starting point, maybe not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkinsjr perkinsjr Awaiting requested review from perkinsjr perkinsjr will be requested when the pull request is marked ready for review perkinsjr is a code owner

@mcstepp mcstepp Awaiting requested review from mcstepp mcstepp will be requested when the pull request is marked ready for review mcstepp is a code owner

@MichaelUnkey MichaelUnkey Awaiting requested review from MichaelUnkey MichaelUnkey will be requested when the pull request is marked ready for review MichaelUnkey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chronark